Sleep Quirk Debugger

Back to the main suspend page

Sending the data back to us

Please review this checklist before sending in quirks.

  1. Have you checked to see if the quirk is already present?
  2. Are you using an up-to-date kernel?
  3. If you using Intel video hardware, are you using the intel driver?
  4. Have you tried suspending multiple times with the new quirk?
  5. Have you tried suspending from X and tty1?

To download the latest hal-info code, just do:

git clone git://git.freedesktop.org/git/hal-info

If you get the error bash: git: command not found you need to install the git source control system. You can do this doing:

[user@localhost ~]$ su -l
Password: xxxxx
[root@localhost ~]# yum -y install git gcc automake
exit

Then we need to copy the changes you made to the file in /usr/share/hal/fdi/information/10freedesktop/ to this local git tree. For example, open the local file using:

cd hal-info
gedit fdi/information/10freedesktop/20-video-quirk-pm-ibm.fdi

Then we can copy the xml from the locally installed fdi (in /usr/share) to this local checked out version. Editing the file in the same way here allows us to generate a patch file that we can sent to the mailing list.

Once you have edited your file, you can check the new addition using the checker scripts. These checker scripts run when you do

./autogen.sh
make check
...
Validate XML in 20-video-quirk-pm-acer.fdi : ok
Validate XML in 20-video-quirk-pm-apple.fdi : ok
Validate XML in 20-video-quirk-pm-asus.fdi : ok
Validate XML in 20-video-quirk-pm-dell.fdi : ok
Validate XML in 20-video-quirk-pm-fujitsu.fdi : ok
Validate XML in 20-video-quirk-pm-hp.fdi : ok
Validate XML in 20-video-quirk-pm-ibm.fdi : ok
Validate XML in 20-video-quirk-pm-lenovo.fdi : ok
Validate XML in 20-video-quirk-pm-misc.fdi : ok
Validate XML in 20-video-quirk-pm-sony.fdi : ok
Validate XML in 20-video-quirk-pm-toshiba.fdi : ok
...

This will check the syntax of all the quirks (and your modification). You can then generate the patch against git, by doing something like:

git pull
git diff master > ../hal-info-quirk-ibm-t60.patch

Now the important bit: If that works, please send your matching data as an attachment to the mailing list (and please also CC richard[at]hughsie[dot]com) and we can add it to future updates to hal-info. This will make other laptops just work in the future and you can get a warm fuzzy feeling inside.

Back to the main suspend page